1 / 33

Using online tools to do informal peer review of PowerBuilder code

Using online tools to do informal peer review of PowerBuilder code. Bruce Armstrong TeamSybase bruce.armstrong@teamsybase.com. Why do code review?. Fewer bugs / improved code quality Lower support costs to remove bugs Improves communication between developers Code is more maintainable

revelin
Download Presentation

Using online tools to do informal peer review of PowerBuilder code

An Image/Link below is provided (as is) to download presentation Download Policy: Content on the Website is provided to you AS IS for your information and personal use and may not be sold / licensed / shared on other websites without getting consent from its author. Content is provided to you AS IS for your information and personal use only. Download presentation by click this link. While downloading, if for some reason you are not able to download a presentation, the publisher may have deleted the file from their server. During download, if you can't get a presentation, the file might be deleted by the publisher.

E N D

Presentation Transcript


  1. Using online tools to do informal peer review of PowerBuilder code Bruce Armstrong TeamSybase bruce.armstrong@teamsybase.com

  2. Why do code review? • Fewer bugs / improved code quality • Lower support costs to remove bugs • Improves communication between developers • Code is more maintainable • Training of junior developers • Cross-training (bus factor)

  3. Types of code review • Formal Inspection (Fagan, et. al.) • Over the shoulder review • Pass around reviews • Pair Programming • Online tool assisted peer review

  4. Formal Inspection • Pros • Highest capture rate / most thorough review • Synergy from team environment • Assurance that defects are corrected • Great deal of metrics are collected • Feedback mechanism for code review process • Cons • Amount of work / time required is significant • Scheduling is difficult • Amount of code to review can be daunting • Running the gauntlet

  5. Over the shoulder review • Pros • Defect capture rate approaching that of formal review • Synergy from team environment • Less resource intensive than formal review • Easier to schedule than formal review • Cons • Metrics are rarely collected • No guarantee that defects were corrected • Amount of code to review can still be daunting • May not provide feedback for process improvement • Still running the gauntlet

  6. Pass around review • Pros • Scheduling is not an issue • Much less resource intensive • Not running the gauntlet • Cons • No metrics are collected • No assurance that reviews are actually being done • No guarantee that defects were corrected • Can be difficult to put review materials together • Lower defect capture rate • Little synergy • No feedback for process improvement

  7. Pair Programming • Pros • Greatest amount of cross-training and junior developer training • Assurance that defects are corrected • Scheduling is not an issue • Cons • Greatest amount of resources required • The “reviewer” is too close to the code, which can reduce the defect capture rate • No feedback for process improvement • No metrics • No synergy outside of the pair

  8. Online tool based peer review • Pros • Scheduling is not an issue • Lower amount of resources required • Synergy maintained • Assurance that defects are corrected • Provides cross-training and junior developer training • Metrics are captured automatically • Not running the guantlet • Cons • May not provide feedback into improving process

  9. Review Landing Page

  10. Creating a Review

  11. Submitting objects for review

  12. Submitting objects for review

  13. Review in Process

  14. Code Diff View

  15. Code summary after rework

  16. Code detail after rework

  17. Integration Tool

  18. CodeCollab.cs

  19. PVCSAPI.cs

  20. Reviews.cs

  21. Versions.cs

  22. Processing the command line

  23. app.config

  24. Submitting for review

  25. Getting Workfiles – 1 of 4

  26. Getting Workfiles – 2 of 4

  27. Getting Workfiles – 3 of 4

  28. Getting Workfiles – 4 of 4

  29. Submitting Workfiles – 1 of 3

  30. Submitting Workfiles – 2 of 3

  31. Submitting Workfiles – 3 of 3

  32. Registering Submit for Review option for the file type

  33. Questions

More Related