Effective Code Review

1. Effective Code Review • Dan Menard

2. Hi. My name is Dan. • I work at Netflix (TV UI Engineer). • I’m Canadian, but I live in California. • I’m galeophobic. • …and I’m here to talk about code review.

3. Everyone should do code review.

4. The Benefits of Code Review • You write better code when you know it will be reviewed. • A second (or third, or fourth…) set of eyes will help spot defects. • More than one person understands your code. • It’s a great way to learn more about the codebase. • It will make you a better developer.

5. What to look (out) for. • Bad Design. • Lack of clarity. • Lack of conformity. • Performance hazards.

6. What’s not important? • Optimization. • Skill and experience gaps. • Personal style.

7. Fitting code review into your dev cycle. • When should you review code? • What level of persistence do you need? • Should you use a code review tool?

8. Code review for geographically dispersed teams. • Helps manage asynchronous coding. • Builds a more cohesive codebase. • Gives you a real status update. • Builds trust and morale.

9. How to sell code review to others. • Not as hard as selling unit tests. • Bottom-up approach. • Just do it.

10. Code review is for everyone. • Small companies, medium-sized companies, large companies. • Open source and closed source. • Pros or amateurs. • Local or remote. • Solo projects are no exception.

11. www.dan-menard.comdaniel.menard@gmail.com@dan_menard